feat(reduce): add thisArg parameter #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisgabriel
force-pushed
the
reduce-thisArg
branch
from
09642b0
to
d0ec7b3
Compare
|
LGTM |
Adds thisArg as third argument to have symmetry with native Array.prototype.reduce(). Relates to ReactiveX#878 and ReactiveX#996.
luisgabriel
force-pushed
the
reduce-thisArg
branch
from
d0ec7b3
to
ef890a8
Compare
|
Just updated with a small bugfix on ScalarObservable::reduce() and adding a test case to cover it. |
|
Looks good to me too. merging.. |
|
@kwonoj please do not merge. There is no |
|
@mattpodwysocki OK, holding. any concerns? |
|
@kwonoj yes, see above comment. This is an unneeded PR. |
|
Fair enough. I think I saw |
|
Whew, appreciate @mattpodwysocki for catching and pointing this out. I could make mistake. |
|
👍 thanks @mattpodwysocki |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
thisArgas the third argument to have symmetry with native Array.prototype.reduce().Relates to #878 and #996.