fix(observable): ensure the subscriber chain is complete before calling this._subscribe #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
force-pushed
the
sync-unsubscribe-fix
branch
from
dc8ac13 to
adee5f4
Compare
|
|
||
| subject.next('foo'); | ||
| subject.complete(); | ||
| subject.next('bar'); | ||
| try { |
There was a problem hiding this comment.
This should probably be:
expect(() => subject.next('bar')).toThrow(new Rx.ObjectUnsubscribedError())Or something like that.
|
once that one small change to the tests is in, LGTM. |
trxcllnt
force-pushed
the
sync-unsubscribe-fix
branch
from
adee5f4 to
4d3eba4
Compare
…ng this._subscribe
trxcllnt
force-pushed
the
sync-unsubscribe-fix
branch
from
4d3eba4 to
756eefc
Compare
|
SHA seems 1631224 . |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If an operator subscriber completed (or unsubscribed) early after receiving values from a synchronous source, the subscribers upstream weren't disposed until after returning from the source's subscribe function. When any downstream subscriber unsubscribes, the upstream subscribers should be notified immediately and unsubscribe all the way to the source subscription.
Related issue (if exists):
@zenparsing pointed this out in #1513
cc: @Blesh