feat(bufferTime): add maxBufferSize optional argument

[figueredo]

Add maxBufferSize to bufferTime as a way of implementing bufferTimeOrCount as discussed in #1295.

[benlesh]

I think it would be better for our end users to allow this operator signature to be more polymorphic.

The following should work:

bufferTime(bufferTimeSpan);  // arguments.length === 1
bufferTime(bufferTimeSpan, scheduler);  // arguments.length === 2 && isScheduler(arguments[1])
bufferTime(bufferTimeSpan, bufferCreationInterval); // arguments.length === 2 && !isScheduler(arguments[1])
bufferTime(bufferTimeSpan, bufferCreationInterval, scheduler); // arguments.length === 3 && isScheduler(arguments[2])
bufferTime(bufferTimeSpan, bufferCreationInterval, maxBufferSize); // arguments.length === 3 && !isScheduler(arguments[2])
bufferTime(bufferTimeSpan, bufferCreationInterval, maxBufferSize, scheduler); // arguments.length === 4

basically, you're going to have to check the length of the arguments, and whether or not the last argument isScheduler in order to determine what's been passed.

[benlesh]

Other than that, it looks like a solid change. Thanks @figueredo

[figueredo]

Yeah, makes much sense, I didn't think of implementing it in that way. I'll change that. Thanks for reviewing, @Blesh.

[figueredo]

Updated the PR making the signature more polymorphic.

[benlesh]

I was thinking on this change over this last week. I wonder if maybe RxJS needs to add the concept of buffers as a type of thing (ala js-csp). I think I'd like to put this change on hold until that's discussed.

[benlesh]

@figueredo I'm unblocking this and I think we can go ahead with a merge. Sorry for the delay. Do you think you can rebase for me?

[figueredo]

@Blesh I'll do it later today. What about the buffers idea (#1609)?

[benlesh]

Merged with cf45540... thanks @figueredo for your contribution! Good stuff!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.