Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AjaxObservable): support withCredentials for CORS request #1758

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jun 9, 2016

Description:

This PR updates AjaxRequest accepts withCredentials flag to be used when create CORS request by setting crossDomain, replicating RXJS-DOM implementation.

Related issue (if exists):

closes #1732, #1711

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.247% when pulling 58ee4ce on kwonoj:dom-crossdomain into 01df713 on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Jun 9, 2016

Looks like there are some new code branches that are not covered.

https://coveralls.io/builds/6534299/source?filename=src%2Fobservable%2Fdom%2FAjaxObservable.ts#L33

@kwonoj
Copy link
Member Author

kwonoj commented Jun 9, 2016

Yes it is, it was bit tough to cover all cases. I'll try to update them.

@kwonoj
Copy link
Member Author

kwonoj commented Jun 9, 2016

Updated couple of test cases to cover basic scenarios of XHR creation.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.46% when pulling 97ca7e8 on kwonoj:dom-crossdomain into 01df713 on ReactiveX:master.

- AjaxRequest now support setting withCredentials flag

closes ReactiveX#1732, ReactiveX#1711
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.46% when pulling 8084572 on kwonoj:dom-crossdomain into 0a6c4e8 on ReactiveX:master.

@kwonoj
Copy link
Member Author

kwonoj commented Jun 18, 2016

I think change's ok, will check in around on this Sunday to next Monday if there isn't any suggestions.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RxJS Observable.ajax cross domain issue
3 participants