fix(WebSocketSubject): ensure all internal state properly reset #1976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the internal socket is
null
-ed out, we weren't ensuring that all other Subjects that are being used internally were also being reset. This caused issues where sometimes internal subjects found themselves in a bad state when you tried to reconnect. This was even more nefarious in multiplexed web sockets.This PR adds a single private method called
_resetState
that will reset the socket and all other Subjects to their original state.fixes #1863