Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TimeoutError): timeout throws typed TimeoutError #1999

Merged
merged 1 commit into from
Oct 4, 2016
Merged

refactor(TimeoutError): timeout throws typed TimeoutError #1999

merged 1 commit into from
Oct 4, 2016

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 4, 2016

Description:
This PR addes TimeoutError to be thrown as default error of timeout.

Related issue (if exists):

closes #1997

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.065% when pulling 74cee2e on kwonoj:error-timeout into d7355c7 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Oct 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.065% when pulling eec927e on kwonoj:error-timeout into 981c0ff on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Oct 4, 2016

LGTM

@kwonoj kwonoj merged commit 1ba0358 into ReactiveX:master Oct 4, 2016
@kwonoj kwonoj deleted the error-timeout branch October 4, 2016 06:41
@kwonoj
Copy link
Member Author

kwonoj commented Oct 4, 2016

Thanks for review! 👍

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout operator doesn't throw typed error
3 participants
@kwonoj @coveralls @benlesh