Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FromEventObservable): remove needless type parameter from FromEventObservable & FromEventPatternObservable #2072

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Oct 25, 2016

Description:

  • By this change, the consumer does not simplify the type to specify to use them
  • BREAKING CHANGE: FromEventObservable<T> & FromEventPatternObservable<T> are no longer take type parameter R.
    You don't have to pass 2nd type parameter.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling 050b0e8 on saneyuki:unused-type-param-FromEventObservable into 260d335 on ReactiveX:master.

@tetsuharuohzeki
Copy link
Contributor Author

update commit messages.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling 2b62e83 on saneyuki:unused-type-param-FromEventObservable into 260d335 on ReactiveX:master.

@tetsuharuohzeki tetsuharuohzeki force-pushed the unused-type-param-FromEventObservable branch from 2b62e83 to fe33304 Compare October 26, 2016 04:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling fe33304 on saneyuki:unused-type-param-FromEventObservable into 0271fab on ReactiveX:master.

@tetsuharuohzeki tetsuharuohzeki force-pushed the unused-type-param-FromEventObservable branch from cecae93 to fe33304 Compare October 27, 2016 03:02
…omEventObservable

BREAKING CHANGE: `FromEventObservable<T>` is no longer take type parameter `R`.
You don't have to pass 2nd type parameter.
…from FromEventPatternObservable

BREAKING CHANGE: `FromEventPatternObservable<T>` is no longer take type parameter `R`.
You don't have to pass 2nd type parameter.
@tetsuharuohzeki tetsuharuohzeki force-pushed the unused-type-param-FromEventObservable branch from fe33304 to 9b74d6d Compare October 27, 2016 03:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.217% when pulling 9b74d6d on saneyuki:unused-type-param-FromEventObservable into 89612b2 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Oct 27, 2016

Coverage Status

Coverage remained the same at 97.217% when pulling fe33304 on saneyuki:unused-type-param-FromEventObservable into 0271fab on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Nov 4, 2016

:shipit:

@benlesh benlesh merged commit f5669fd into ReactiveX:master Nov 4, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants