fix(race): unsubscribe raced observables with immediate scheduler #2158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes a bug with the
race
operator: whenever a raced Observable emitted a value immediately when subscribed (with the default scheduler), any following Observables were subscribed but never unsubscribed.Now, if any raced Observable emits a value immediately, any latter Observables are ignored, because for them "the race is already lost".
Also, it is now ensured that the immediately emitting Observable is still added to the
RaceSubscriber
and will be unsubscribed once the outer Observable is unsubscribed.