fix(groupBy): Fix groupBy to dispose of outer subscription. #2201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how groupBy is passing current unit tests, as we seem to be covering this case.
This PR fixes a bug where groupBy wasn't unsubscribing from its source when the outer subscription has been disposed and all inner subscriptions are inactive.
If you see here, the inner refCount subscription calls
parent.unsubscribe()
ifparent.count === 0
andparent.attemptedToUnsubscribe
is true. But the parent only unsubscribes ifparent.attemptedToUnsubscribe
is false, which means the subscription to the source is never disposed.This is easily replicated with groupBy on a Subject, where you'll see the observers list grow indefinitely.