Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Subscription): Limit Subscription::closed public accessibility to readonly #2234

Closed
wants to merge 3 commits into from
Closed

fix(Subscription): Limit Subscription::closed public accessibility to readonly #2234

wants to merge 3 commits into from

Commits on Jan 1, 2017

  1. fix(Subscription): limit Subscription::closed public accessibility to… 

    … readonly

BREAKING CHANGE: Cannot change isClosed state without unsubscribe()
    @kwonoj
    kwonoj committed Jan 1, 2017
    Configuration menu
    Copy the full SHA
    c1ab17c View commit details
    Browse the repository at this point in the history

  2. fix(Subscription): update inherited Subscription behavior

    @kwonoj
    kwonoj committed Jan 1, 2017
    Configuration menu
    Copy the full SHA
    3330c70 View commit details
    Browse the repository at this point in the history

  3. test(ScalarObservable): update test case did not do any assertion

    @kwonoj
    kwonoj committed Jan 1, 2017
    Configuration menu
    Copy the full SHA
    b64e50c View commit details
    Browse the repository at this point in the history