fix(reduce): forward index to accumulator #2291
Conversation
|
|
||
| if (!this.hasSeed) { | ||
| this.index++; | ||
| } |
There was a problem hiding this comment.
Why does index start at 1 if there is no seed?
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/Reduce
currentIndex The index of the current element being processed in the array. Starts at index 0, if an initialValue is provided, and at index 1 otherwise.
I tried to follow same behavior to native reduce, where it says start from 0 if seed exists, 1 otherwise.
There was a problem hiding this comment.
maybe I've read spec incorrectly?
There was a problem hiding this comment.
@kwonoj Nope, you read it correctly. TIL.
There was a problem hiding this comment.
Maybe worth documenting this behaviour in the RxJs documentation?
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This PR updates
reduceto forward index of an element as same as native reduce operator does.Related issue (if exists):