Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): mirror source if durations are Observable.empty() #2595

Merged
merged 2 commits into from
Jun 14, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/operators/audit-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,18 @@ describe('Observable.prototype.audit', () => {
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should mirror source if durations are Observable.empty()', () => {
const e1 = hot('abcdefabcdefabcdefabcdefa|');
const e1subs = '^ !';
const e2 = Rx.Observable.empty();
const expected = 'abcdefabcdefabcdefabcdefa|';

const result = e1.audit(() => e2);

expectObservable(result).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should emit no values if duration is a never', () => {
const e1 = hot('----abcdefabcdefabcdefabcdefa|');
const e1subs = '^ !';
Expand Down
7 changes: 6 additions & 1 deletion src/operator/audit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ class AuditSubscriber<T, R> extends OuterSubscriber<T, R> {
if (duration === errorObject) {
this.destination.error(errorObject.e);
} else {
this.add(this.throttled = subscribeToResult(this, duration));
const innerSubscription = subscribeToResult(this, duration);
if (innerSubscription.closed) {
this.clearThrottle();
} else {
this.add(this.throttled = innerSubscription);
}
}
}
}
Expand Down