chore(typescript): Cleanup usage of typings package.

[alexeagle]

TypeScript now distributes typings via npm.

Note, @types is not semver, because patch releases may introduce syntax that requires a TypeScript upgrade. So the package.json pins these to versions (just as the typings.json did)

[kwonoj]

related to #2437.

[rxjs-bot]

	Fails
🚫	Running your Dangerfile has Failed

Danger has errored

Error: Error

Error: Cannot find module 'package.json'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at getBabelRC (/home/travis/build/ReactiveX/rxjs/node_modules/babel-jest/build/index.js:53:41)
    at Object.getCacheKey (/home/travis/build/ReactiveX/rxjs/node_modules/babel-jest/build/index.js:90:14)
    at ScriptTransformer._getCacheKey (/home/travis/build/ReactiveX/rxjs/node_modules/jest-runtime/build/ScriptTransformer.js:68:26)
    at ScriptTransformer._getFileCachePath (/home/travis/build/ReactiveX/rxjs/node_modules/jest-runtime/build/ScriptTransformer.js:93:27)
    at ScriptTransformer.transformSource (/home/travis/build/ReactiveX/rxjs/node_modules/jest-runtime/build/ScriptTransformer.js:182:32)
    at ScriptTransformer._transformAndBuildScript (/home/travis/build/ReactiveX/rxjs/node_modules/jest-runtime/build/ScriptTransformer.js:275:40)

Generated by 🚫 dangerJS

[kwonoj]

danger checker seems off, don't mind it - I'll look into separately.

[alexeagle]

From the other issue you linked, it's not clear to me if this PR causes some problem - do we need testing of user-land type-checking?

[kwonoj]

it's not clear to me if this PR causes some problem

: that's reason we were hesitating migrate into @types package. Surprisingly we had regressions by shipping pkg using @types pkg from typings pkg previously, and haven't introduced automatic way to verify those in our repo. It's not about testing 3rd party typing's validity, it was using those pkg TS compiler generated unexpected results. I believe that's no longer issue though.

[alexeagle]

Sounds like you would benefit from the same typings test setup we use for angular.

…

On Wed, May 24, 2017, 11:36 AM OJ Kwon ***@***.***> wrote: it's not clear to me if this PR causes some problem : that's reason we were hesitating migrate into @types <https://github.com/types> package. Surprisingly we had regressions by shipping pkg using @types <https://github.com/types> pkg from typings pkg previously, and haven't introduced automatic way to verify those in our repo. It's not about testing 3rd party typing's validity, it was using those pkg TS compiler generated unexpected results. I believe that's no longer issue though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5I26KxITNxWTJPw3jtLADe_WSb6KQks5r9HiygaJpZM4Nlfmg> .

[benlesh]

I've merged this into #2614. Closing in favor of that.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.