Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(groupBy): fix a typo in the example of the instance operator gro… #2619

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

SangKa
Copy link
Contributor

@SangKa SangKa commented May 27, 2017

hi, @benlesh. I'm working in progress on Chinese localization of the RxJS 5 official document.
During this process I find something wrong such as a typo, a problematic example code.
I will report these issues consistently for making RxJS better.
By the way, I'm your huge fan.

Description:
In the second example of groupBy operator, there is a typo(anme) in the example code as belowing:
.groupBy(p => p.id, p => p.anme)

Related issue (if exists):

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.735% when pulling b2459dc on SangKa:fix-groupBy-docs-example into da96b6a on ReactiveX:master.

@staltz
Copy link
Member

staltz commented May 30, 2017

LGTM

@benlesh benlesh merged commit 25a3d64 into ReactiveX:master Jun 14, 2017
@benlesh
Copy link
Member

benlesh commented Jun 14, 2017

Thank you @SangKa

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants