Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Subject): lift signature is now appropriate for stricter TS 2.4 c… #2722

Merged
merged 1 commit into from
Jul 5, 2017
Merged

fix(Subject): lift signature is now appropriate for stricter TS 2.4 c… #2722

merged 1 commit into from
Jul 5, 2017

Commits on Jul 5, 2017

  1. fix(Subject): lift signature is now appropriate for stricter TypeScri… 

    …pt 2.4 checks

Type safety wasn't really gauranteed with lift before because we survived for a long time with an incorrect type signature, TypeScript 2.4 introduces stricter type-checking, and all of a sudden `lift` on `Subject` was breaking builds for those that are riding the wave of the latest-and-greatest.
    @benlesh
    benlesh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    8ed7054 View commit details
    Browse the repository at this point in the history