Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shareReplay): properly retains history on subscribe #2910

Merged
merged 1 commit into from
Oct 6, 2017
Merged

fix(shareReplay): properly retains history on subscribe #2910

merged 1 commit into from
Oct 6, 2017

Commits on Oct 6, 2017

  1. fix(shareReplay): properly retains history on subscribe 

    When the refCount hits zero, and the source has neither completed nor errored, `shareReplay` will now properly stay subscribed to the source, and retain the internal ReplaySubject that is caching values

fixes #2908
    @benlesh
    benlesh committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    75efb00 View commit details
    Browse the repository at this point in the history