Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: inline CJS source maps #2970

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Conversation

jasonaden
Copy link
Collaborator

Fixes #2934

We need to fix the source maps for CJS code. There is a better way to do it (by properly fixing all the paths in the source maps), but due to time constraints right now, this is the most reliable way to do it. It means the map files will contain the content of the source they are mapping. It's the most fail-safe way to distribute source maps, so should fix #2934 so 5.5 can get out of beta.

@rxjs-bot
Copy link

Messages
📖

CJS: 2274.4KB, global: 745.4KB (gzipped: 139.9KB), min: 145.5KB (gzipped: 30.9KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 97.412% when pulling 7c0c8f4 on jasonaden:inline_cjs_sources into 09c6003 on ReactiveX:master.

@benlesh benlesh merged commit 39b4af5 into ReactiveX:master Oct 18, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include sourcesContent in source-maps in npm package
5 participants