Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up typescript to latest #3009

Merged
merged 4 commits into from
Oct 30, 2017
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 27, 2017

Description:
This PR bumps up tsc / type definition (typings) into latest. PR intentionally picks tsc version to latest, let master branch try to build on latest release always to check regressions earlier.

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Oct 27, 2017

/cc @benlesh . I'll check this in myself, cc'ing for visibility.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 27, 2017

Uh forgot error object thing. :/

@rxjs-bot
Copy link

Messages
📖

CJS: 1396.8KB, global: 756.0KB (gzipped: 120.9KB), min: 146.9KB (gzipped: 31.5KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 97.329% when pulling 9a1ff90 on kwonoj:bump-typescript into 040d951 on ReactiveX:master.

@kwonoj kwonoj requested a review from benlesh October 27, 2017 16:38
@kwonoj
Copy link
Member Author

kwonoj commented Oct 27, 2017

Error object change is basically cherry picking d242156 merged in next previously.

@benlesh
Copy link
Member

benlesh commented Oct 30, 2017

@kwonoj what is dependency cruiser? Is it required for this change? Can we discuss it and perhaps move it to a different PR?

@kwonoj
Copy link
Member Author

kwonoj commented Oct 30, 2017

@benlesh it's replacement to madge for circular ref check. It should be included in this PR, cause madge has inner peer dep prevented to bump up ts recently. (Jay hits this). Course we can discuss if needed, but not as a separate PR.

@benlesh
Copy link
Member

benlesh commented Oct 30, 2017

@kwonoj right on

:shipit:

@benlesh benlesh merged commit 2f395da into ReactiveX:master Oct 30, 2017
@kwonoj kwonoj deleted the bump-typescript branch October 30, 2017 15:48
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants