Removing tests that don't make any sense #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test wasn't testing anything, it was passing the partition function itself to the expect(), which doesn't really do anything of value.
These tests were really testing the rethrowing capability of Observable, as triggered when the scheduler was flushed. The call directly above the flush to `repeat` does nothing but create a new observable that is never subscribed to
Generated by 🚫 dangerJS |
-+12.4KB-red.svg?style=flat-square){kind=icon}
-+2.5KB-red.svg?style=flat-square){kind=icon}
kwonoj
reviewed
Oct 27, 2017
| @@ -255,11 +255,6 @@ describe('Observable.prototype.partition', () => { | |||
| expectSubscriptions(e1.subscriptions).toBe([e1subs, e1subs]); | |||
| }); | |||
|
|
|||
| it('should throw without predicate', () => { | |||
| const e1 = hot('--a-b---a------d----'); | |||
| expect(e1.partition).to.throw(); | |||
There was a problem hiding this comment.
shouldn't we just correct it into expect(() => e1.partition.subscribe)).to.throw?
There was a problem hiding this comment.
I'm not sure it should throw... it doesn't throw now and none of our other methods throw... for example, if you don't provide a predicate to filter.
Perhaps they should throw... but it seems unrelated.
kwonoj
approved these changes
Oct 30, 2017
|
🚢 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few slip past the radar on us that weren't really testing anything of value. See the commit messages for more detail.