fix(TSC): Fixing TSC errors. Fixes #3020 #3022
Conversation
Generated by 🚫 dangerJS |
-+13.3KB-red.svg?style=flat-square){kind=icon}
-+2.9KB-red.svg?style=flat-square){kind=icon}
| @@ -16,10 +16,11 @@ | |||
| "es2015.collection", | |||
| "es2015.promise", | |||
| "dom" | |||
| ] | |||
| ], | |||
| "types": ["mocha", "node"] | |||
There was a problem hiding this comment.
my other codebases does have types for these globals but didn't require this explicitly 🤔 any idea why it's needed?
There was a problem hiding this comment.
Probably because you were declare-ing things like describe() and it() somewhere else; but hey, this seems like the right thing to do and it fixes the errors so... yeah, LGTY?
|
@davidkpiano I tried your PR with merged, and it actually doesn't work - I'm reverting currently merged one. You may able to try run tsc directly (not via npm script) on root of repo without any option to see what happens. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description: This fixes all the warnings output by running
tscat the project's root by adding types fornodeandmocha, and also fixing a TS4023 issue.Related issue (if exists): #3020