Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use pipe method for showing usage of operators as pure functions #3187

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

fahad19
Copy link
Contributor

@fahad19 fahad19 commented Dec 15, 2017

Description:

The operators creation guide was recommending the usage of let method in Observables.

But from v5.5, we have lettable operators. Better suggest new users to use pipe instead.

@rxjs-bot
Copy link

Messages
📖

CJS: 1383.5KB, global: 752.4KB (gzipped: 120.7KB), min: 145.3KB (gzipped: 31.4KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.079% when pulling aefe7c8 on fahad19:pipe-method into efcd922 on ReactiveX:master.

@benlesh benlesh merged commit d5ced68 into ReactiveX:master Dec 15, 2017
@benlesh
Copy link
Member

benlesh commented Dec 15, 2017

Thank you very much for your contribution!

@fahad19 fahad19 deleted the pipe-method branch December 15, 2017 22:06
@fahad19
Copy link
Contributor Author

fahad19 commented Dec 15, 2017

@benlesh: that was very quick of you to take care of this! thanks! 🎉

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants