Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typings): the return type of project of mergeScan should be ObservableInput<R> #3197

Merged
merged 1 commit into from
Dec 28, 2017
Merged

fix(typings): the return type of project of mergeScan should be ObservableInput<R> #3197

merged 1 commit into from
Dec 28, 2017

Conversation

Brooooooklyn
Copy link
Contributor

Description:
should be able to use async await in mergeScan

Observable.of(1, 2, 3)
  .pipe(
    mergeScan(async (acc, cur) => {
      await sleep(cur)
      acc.push(cur)
      return acc
    }, [])
  )

Related issue (if exists):

@rxjs-bot
Copy link

Messages
📖

CJS: 1383.5KB, global: 752.4KB (gzipped: 120.7KB), min: 145.3KB (gzipped: 31.4KB)

Generated by 🚫 dangerJS

kwonoj
kwonoj approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, leave open for another eye.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.08% when pulling 23fe17d on Brooooooklyn:issue/merge-scan-typings into c9f69ad on ReactiveX:master.

@kwonoj kwonoj merged commit c1721e3 into ReactiveX:master Dec 28, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@benlesh benlesh benlesh approved these changes

Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Brooooooklyn @rxjs-bot @coveralls @kwonoj @benlesh