Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): the return type of factory of defer should be ObservableInput<T> #3211

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Jan 4, 2018

should be able to defer a ArrayLike result

Observable.defer(() => [1, 2, 3])

@rxjs-bot
Copy link

rxjs-bot commented Jan 4, 2018

Messages
📖

CJS: 1381.5KB, global: 750.2KB (gzipped: 120.6KB), min: 145.4KB (gzipped: 31.4KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.08% when pulling fa88d3d on Brooooooklyn:issue/defer-type into c1721e3 on ReactiveX:master.

Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks..legit to me?

@coveralls
Copy link

coveralls commented Jan 13, 2018

Coverage Status

Coverage remained the same at 97.097% when pulling 353cb87 on Brooooooklyn:issue/defer-type into 1a363ad on ReactiveX:master.

@benlesh benlesh merged commit dc41a5e into ReactiveX:master Jan 23, 2018
@benlesh
Copy link
Member

benlesh commented Jan 23, 2018

Thanks, @Brooooooklyn!

acutmore pushed a commit to youviewtv/rxjs-5 that referenced this pull request Jan 23, 2018
@felixfbecker
Copy link
Contributor

Closes #2586

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants