fix(isArrayLike): reject functions because functions have "length" #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
requested changes
Apr 13, 2018
spec/observables/from-spec.ts
Outdated
| // for the purpose of making a nice diagram, spread out the synchronous emissions | ||
| .concatMap((x, i) => of(x).delay(i === 0 ? 0 : 20, rxTestScheduler)); | ||
| const expected = 'x-y-(z|)'; | ||
| expectObservable(e1).toBe(expected, { x: 10, y: 20, z: 30 }); |
There was a problem hiding this comment.
Can we undo the formatting changes?
| @@ -118,5 +119,26 @@ describe('from', () => { | |||
| ); | |||
| expect(nextInvoked).to.equal(false); | |||
| }); | |||
| it(`should accept a function`, (done) => { | |||
There was a problem hiding this comment.
from should not accept a function.
from((...args) => subject.next(...args)) should not work and should error.
The change to isArrayLike I can understand, I'm uncertain about this test.
There was a problem hiding this comment.
if from accepts a Promise, shouldn't it be able to accept a handler?
There was a problem hiding this comment.
I see, the function has Symbol.observable on it. I missed that. Apologies.
benlesh
approved these changes
Apr 13, 2018
|
Thanks @johnlindquist <3 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a
typeof x !== "function"check toisArrayLike.isArrayLikewas only checking forlengthand functions have alengthproperty. This prevented functions from properly falling through to this case:rxjs/src/internal/util/subscribeTo.ts
Line 31 in 6fd1fd7