chore(test): fix scheduler and subject types #3748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
approved these changes
May 29, 2018
| @@ -71,11 +71,11 @@ describe('Scheduler.asap', () => { | |||
| const fakeTimer = sandbox.useFakeTimers(); | |||
| // callThrough is missing from the declarations installed by the typings tool in stable | |||
| const stubSetInterval = (<any> sinon.stub(global, 'setInterval')).callThrough(); | |||
| function dispatch(state: any): void { | |||
| function dispatch(this: any, state: any): void { | |||
There was a problem hiding this comment.
I'd love a second pass that removes some of the any types that are being added, but that shouldn't block the PR.
|
Waiting to see if @kwonoj can restart the build. |
|
@david-driscoll I can probably get rid of some of those this-parameter anys pretty quickly with judicious use of |
|
retriggered build. |
|
@david-driscoll Used appropriate types instead of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Continues from PR #3680 and fixes tests for schedulers and subjects.
This should be the last of the fixes.
After this is merged, I'll remove the
test_checkscript and will changetestto include type checking. I'll also create atest_fastscript - which will be the same astest, but without the type checking - for use with watched builds, etc., as I suspect the type checking will take several seconds.Related issue (if exists): #3411 #3680