Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): mention util interfaces in migration import paths #3884

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

martinsik
Copy link
Contributor

Description:

I added mentions of SubscriptionLike and PartialObserver into "Import paths" migration guide: https://github.com/ReactiveX/rxjs/blob/master/docs_app/content/guide/v6/migration.md#import-paths

The first bullet point already says:

  1. rxjs: Creation methods, types, schedulers and utilities

so I only added SubscriptionLike and PartialObserver because these two are most common util interfaces I think.

Related issue (if exists):

#3681

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.945% when pulling 0a8f418 on martinsik:issue-3681 into 01a0978 on ReactiveX:master.

@benlesh benlesh merged commit f9318d8 into ReactiveX:master Jul 3, 2018
@benlesh
Copy link
Member

benlesh commented Jul 3, 2018

Makes sense, thanks @martinsik!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants