Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #2457 for v6 #3963

Merged
merged 3 commits into from
Jul 29, 2018
Merged

Refactor #2457 for v6 #3963

merged 3 commits into from
Jul 29, 2018

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jul 27, 2018

Description:

This PR refactors #2457 for v6 and changes a few identifiers so that they are prefixed with underscores.

/cc @jayphelps

I did try to use git-blame-someone-else to credit the PR's author, but the command left the branch in an indeterminate state, so I just aborted the rebase. If someone else wants to have a crack at updating the PR - to credit the author - the author's details are:

Mateusz Podlasin <Podlas29@gmail.com>

UPDATE: I've edited the commits manually to credit the author.

Related issue (if exists): #2457 #2459

@cartant
Copy link
Collaborator Author

cartant commented Jul 28, 2018

@benlesh I've used git rebase -i to edit the commits manually, so that they are now attributed to the original PR's author.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.763% when pulling 5d16ce4 on cartant:pr-2457 into 5c52a73 on ReactiveX:master.

@benlesh benlesh merged commit a518b00 into ReactiveX:master Jul 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018
@cartant cartant deleted the pr-2457 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants