Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(find): unsubscribe from source when found #3968

Merged
merged 5 commits into from
Aug 1, 2018
Merged

fix(find): unsubscribe from source when found #3968

merged 5 commits into from
Aug 1, 2018

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jul 28, 2018

Description:

Fixes #3934 and adds unsubscribe-when-matched tests for find, findIndex and first.

Related issue (if exists): #3934

@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 96.738% when pulling 7f259cb on cartant:issue-3934 into 5c52a73 on ReactiveX:master.

@benlesh benlesh merged commit fd01f7b into ReactiveX:master Aug 1, 2018
@benlesh
Copy link
Member

benlesh commented Aug 1, 2018

Awesome! Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 31, 2018
@cartant cartant deleted the issue-3934 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartant @coveralls @benlesh