Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zip): ensure zip observable completes properly #400

Closed
wants to merge 1 commit into from
Closed

fix(zip): ensure zip observable completes properly #400

wants to merge 1 commit into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Sep 24, 2015

  • adds additional tests
  • outerIndex is now public on InnerSubscriber
  • updates zip to complete when any inner observable has completed and its buffer is empty

relates to #397

@benlesh
fix(zip): ensure zip observable completes properly
7474d9f 
- adds additional tests
- outerIndex is now public on InnerSubscriber
- updates zip to complete when any inner observable has completed and its buffer is empty

relates to #397
@benlesh
Copy link
Member Author

benlesh commented Sep 24, 2015

This is an alternative PR to #399

Ops per second here are ~89,000 ... discussion is in #399.

@ReactiveX ReactiveX locked and limited conversation to collaborators Sep 24, 2015
@benlesh
Copy link
Member Author

benlesh commented Sep 25, 2015

Closing this in favor of #399.

@benlesh benlesh closed this Sep 25, 2015
@benlesh benlesh deleted the zip_fixes branch December 16, 2016 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benlesh