Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dtslint): add dtslint test for endWith operator (#4093) #4175

Merged
merged 1 commit into from
Sep 25, 2018
Merged

test(dtslint): add dtslint test for endWith operator (#4093) #4175

merged 1 commit into from
Sep 25, 2018

Conversation

dkosasih
Copy link
Contributor

Description: add dtslint test for endWith operator

Related issue (if exists): #4093

@coveralls
Copy link

coveralls commented Sep 24, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 96.808% when pulling c928cc1 on dkosasih:dtslint-endwith into 687a3ce on ReactiveX:master.

timdeschryver
timdeschryver reviewed Sep 24, 2018
View reviewed changes
Copy link
Contributor

@timdeschryver timdeschryver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test with wrong parameters could be added here. e.g. endWith() and endWith('foo')?

@dkosasih
Copy link
Contributor Author

Added a couple of tests to cover you scenario. Empty parameter is accepted.

cartant
cartant approved these changes Sep 25, 2018
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartant
Copy link
Collaborator

cartant commented Sep 25, 2018 •
edited
Loading

This looks good to me, but it's highlighted that endWith needs to be brought into like with startWith in that it should be possible to pass values of any type and the type should be widened.

I think you made those changes to startWith, so would you like to change endWith, too?

BTW, in a separate PR, please, but I'll wait until I've heard from you before merging this one.

@dkosasih
Copy link
Contributor Author

@cartant it wasn't me, I think @timdeschryver did.
I can create a new issue and you can assign it to me. sounds OK?

@cartant cartant merged commit 7eeb671 into ReactiveX:master Sep 25, 2018
@dkosasih dkosasih deleted the dtslint-endwith branch September 25, 2018 03:25
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkosasih @coveralls @cartant @timdeschryver