fix(pluck): key union type strictness #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait... does the loosely typed key inputs actually desired behavior? I mean it's valid JavaScript runtime code but shall the TS add the extra checking over here? |
imcotton
force-pushed
the
fix-pluck
branch
2 times, most recently
from
f47b849
to
69d416b
Compare
Pull Request Test Coverage Report for Build 8147
💛 - Coveralls |
benlesh
approved these changes
Feb 25, 2019
|
this change is likely to break a few people, so I'm going to target it at the next major version |
Good call. BTW, I've made rebase & squash for easy picking up later on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing the overloading type define
off-by-onebeing widen