chore: use local TypeScript with dtslint #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Pull Request Test Coverage Report for Build 8352
💛 - Coveralls |
cartant
changed the title
benlesh
approved these changes
Apr 16, 2019
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
* chore: replace prepublish with prepublishOnly * chore: use local typescript with dtslint * chore: restore commented-out dtslint tests * chore: replace prepublishOnly with prepublish
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reconfigures dtslint to use the locally-installed version of TypeScript - i.e. the version with which RxJS is built.
The command must be passed an absolute path to the directory that contains
typescript.jsas said path is passed torequirein two files within the dtslint implementation that reside in different directories - so each has a different relative path the the locally-installed TypeScript. To account for this, dtslint is now invoked viaspec-dtslint/script.js.This PR also restores numerous tests that had to be commented out due to the different behaviour of
typescript@next.Oh, and I changedNever mind. It seems the CI build depends upon all that stuff happening after anprepublishtoprepublishOnlyas I was tired of having the build and tests run whenever I did annpm ci. Now, that stuff will only run before an actual publish.npm install. 😒Related issue (if exists): #4705