fix: use unknown type for errors
#5084
Conversation
| @@ -61,21 +61,21 @@ export type InteropObservable<T> = { [Symbol.observable]: () => Subscribable<T>; | |||
| export interface NextObserver<T> { | |||
| closed?: boolean; | |||
| next: (value: T) => void; | |||
| error?: (err: any) => void; | |||
| error?: (err: unknown) => void; | |||
There was a problem hiding this comment.
There might be other places to update this.
|
I recall we had discussion similar to this but can't clearly remember conclusion. Regardless, I believe this should be breaking changes. |
|
Yeah, this would be a breaking change. And I'm not sure it's correct. Sure, the type of error is "unknown", but the error could also literally be anything. This change would force everyone to explicitly define the type of error they think they're going to get, and would be a pretty massive breaking change for people. We can discuss this at the next team meeting, but I'm going to say it's unlikely we'll be willing to introduce such a massive breakage for TS users in this next version. |
|
Related: #5066 (comment) Basically, I don't think we should make changes to this until TypeScript does, too - e.g. for |
|
We've decided to leave as-is, until TS does something similar with Promise's error path. |
Description:
Errors can be of any type.
unknownis preferable toany, asanycompletely disables type checking: