Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mapTo): update function signature #5102

Merged
merged 1 commit into from
Jan 22, 2020
Merged

refactor(mapTo): update function signature #5102

merged 1 commit into from
Jan 22, 2020

Conversation

alaboudi
Copy link
Contributor

Description:
Reduce the number of generics used in the 'mapTo' function to 1 generic parameter. Mark the 2 generic variant as a deprecated variant

Related issue (if exists):
issue #5090

Reduce the number of generics used in the 'mapTo' function to 1 generic parameter. Mark the 2 generic variant as a deprecated variant

Fixes #5090
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 1e7d469 into ReactiveX:master Jan 22, 2020
@benlesh
Copy link
Member

benlesh commented Jan 22, 2020

Thank you @alaboudi!

@alaboudi alaboudi deleted the fix-mapTo-type branch January 23, 2020 02:07
kwonoj pushed a commit to kwonoj/rxjs that referenced this pull request Feb 5, 2020
Reduce the number of generics used in the 'mapTo' function to 1 generic parameter. Mark the 2 generic variant as a deprecated variant

Fixes ReactiveX#5090
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
Reduce the number of generics used in the 'mapTo' function to 1 generic parameter. Mark the 2 generic variant as a deprecated variant

Fixes ReactiveX#5090
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants