fix(fromFetch): abort signal ignored if already aborted #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
requested changes
Oct 26, 2019
Modifying the object can lead to problems if the init object is reused in multiple calls to fromFetch.
bgotink
force-pushed
the
fix/fetch-signal
branch
from
c5f4a69
to
4774083
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix two issues with abort signal handling in
fromFetch:signalproperty on the init object was modified, which could lead to issues if the init object is reused for multiple requests.fromFetchfunction basically ignored the incoming signal if it is already aborted.Related issue (if exists):