Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace dtslint with dtslint-like rules in tslint-etc #5123

Merged
merged 6 commits into from
Nov 11, 2019

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Nov 4, 2019

Description:

This PR removes dtslint and replaces it with an expect-type rule - in tslint-etc - that is a modified version of the expect rule from the dtslint package (which is MIT licensed). Essentially, this PR reduces the number of moving parts in the type tests.

The modified rule uses the locally-installed typescript - i.e. the typescript version specified in the RxJS package.json file - and removes the performance-related code that attempts to write profiling data to the caller's home directory.

Instead of running dtslint, we can now run tslint directly - passing it the tsconfig.json and the tslint.json files that are in the spec-dtslint directory - and can be sure that dtslint isn't doing anything weird in its implementation.

Also, I've added an expect-deprecation rule to tslint-etc which will allow us to ensure that our deprecations are working as they should, like this:

of<number>(); // $ExpectDeprecation
of(); // $ExpectNoDeprecation

I'll start adding more deprecation-related tests once/if this is merged.

And there is a no-dtslint-typo rule to catch some of the invalid dtslint-like expectations - like these - that have crept into the codebase.

Related issue (if exists): #4871

@benlesh benlesh merged commit ec77f3f into ReactiveX:master Nov 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
@cartant cartant deleted the dtslint-expect-deprecation branch September 24, 2020 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants