Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix build errors #5256

Merged
merged 1 commit into from
Jan 22, 2020
Merged

chore: fix build errors #5256

merged 1 commit into from
Jan 22, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 22, 2020

I'm getting build errors since our updates to strictness. They revolved around the call signatures of SchedulerLike and SchedulerAction in a few operators. This resolves that by being a little more explicit.

cartant
cartant approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would be interested to see the error effected and the circumstances involved, as the package built fine in the strict PR. Is the error in this package or an external one?

@benlesh
Copy link
Member Author

benlesh commented Jan 22, 2020

It was in this package. After I cleared node_modules and rebuilt locally I was getting errors (valid ones) in operators that used scheduling like windowTime.

@benlesh benlesh merged commit fa13149 into ReactiveX:master Jan 22, 2020
kwonoj pushed a commit to kwonoj/rxjs that referenced this pull request Feb 5, 2020
@benlesh @kwonoj
chore: fix build errors in master (ReactiveX#5256)
dc1b084
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
@benlesh
chore: fix build errors in master (ReactiveX#5256)
db92ff8
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant