Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Create Deprecation page per deprecation group #5426

Merged
merged 5 commits into from
Sep 24, 2020

Conversation

niklas-wortmann
Copy link
Member

This is a rough POC to see if it works for our purpose to improve the deprecation messages.

Text might need some improvement/additional information
@benlesh @cartant

@cartant cartant added the AGENDA ITEM Flagged for discussion at core team meetings label Jun 17, 2020
@cartant
Copy link
Collaborator

cartant commented Jun 17, 2020

Fixed some typos that were pointed out above and rebased onto master.

There are some deprecation messages that still include the {@ ... } markup that's discussed here. IMO, it would be best to remove these ATM, as they clutter the output in VS code and on the command line. Apart from that, this LGTM and, IMO, improvements regarding the deprecations need to be incorporated into the docs ASAP. I suppose it's too late/difficult to make changes to v6, at this stage, but v7 needs better messages and docs before it can be released, IMO.

@cartant
Copy link
Collaborator

cartant commented Jun 24, 2020

FWIW, we really should try to get the deprecation messages sorted before this lands:

https://mobile.twitter.com/WenluWang/status/1275458404132073473

We should really fix them in v6 too, as people are going to be using that for a while in Angular, etc.

@benlesh benlesh self-assigned this Jul 29, 2020
docs_app/content/deprecations/scheduler-argument.md Outdated Show resolved Hide resolved
docs_app/content/deprecations/scheduler-argument.md Outdated Show resolved Hide resolved
docs_app/content/deprecations/scheduler-argument.md Outdated Show resolved Hide resolved
@cartant cartant merged commit d52c766 into ReactiveX:master Sep 24, 2020
@benlesh benlesh removed their assignment Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGENDA ITEM Flagged for discussion at core team meetings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants