Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix up notification types #5478

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix: fix up notification types #5478

merged 2 commits into from
Jun 23, 2020

Commits on Jun 22, 2020

  1. fix: fix up notification types 

    - Ensures Notification methods only accept appropriate arguments
- Ensures Arbitrary objects of the proper shape my be passed through dematerialized
- Utilizes hot path functions to create lightweight objects for internal notification use
- Deprecates the Notification class
- Adds a deprecation message for materialize to notify users that soon the emitted object type will change to not have all of the same methods as Notification
- Updates a few tests that were relying on the shape of Notification instances to pass, as we are now using POJOs internally in the TestScheduler
- Adds dtslint tests for notifications
- Adds dtslint tests to enforce types on dematerialize

BREAKING CHANGE: Notification.createNext(undefined) will no longer return the exact same reference everytime.

BREAKING CHANGE: Type signatures tightened up around Notification and dematerialize
    @benlesh
    benlesh committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    169a3a8 View commit details
    Browse the repository at this point in the history

  2. chore: address comments

    @benlesh
    benlesh committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    199869b View commit details
    Browse the repository at this point in the history