refactor(Observable): Update property and method types #5572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_isScalar
as it was unusedlift
protected
. This is an internal implementation detail.source
protected
, this is an internal implementation detail.BREAKING CHANGE:
lift
no longer exposed. It was NEVER documented that end users of the library should be creating operators usinglift
. Lift has a variety of issues and was always an internal implementation detail of rxjs that might have been used by a few power users in the early days when it had the most value. The value oflift
, originally, was that subclassedObservable
s would compose through all operators that implemented lift. The reality is that feature is not widely known, used, or supported, and it was never documented as it was very experimental when it was first added. Until the end of v7,lift
will remain on Observable. Standard JavaScript users will notice no difference. However, TypeScript users might see complaints aboutlift
not being a member of observable. To workaround this issue there are two things you can do: 1. Rewrite your operators as outlined in the documentation, such that they returnnew Observable
. or 2. cast your observable asany
and accesslift
that way. Method 1 is recommended if you do not want things to break when we move to version 8.