fix(publish,publishReplay) resolve sharing Subject when subscribing to different source observables

[e-davidson]

Description:

Fixes the issue when using the publish or publishReplay operator in a pipe that's shared with different source observables.

For more details see #5411

• change publish operator to use factory
• change publishReplay operator to not share ReplaySubject

Related issue (if exists):

• fixes issue reusing publish or publishReplay in a pipe can subscribe to the wrong data source #5411

[cartant]

This behaviour is by design and these changes would be breaking.

[e-davidson]

I'd be happy to make it backwards compatible. It's unclear where the breaking change would occur since the tests didn’t break. Would you be able to point me in the right direction?

[cartant]

The change to src/internal/operators/publishReplay.ts looks to me to be breaking. Changing it to use a factory will effect different behaviour, AFAICT.

In any case, I'm these APIs are likely to be deprecated and replaced. See #5432, #5431 and other issues/PRs linked therein.

[cartant]

I shouldn't have blocked this, @e-davidson

It does significantly change behaviour, but it's not behaviour that anyone could reasonably be relying upon - so it's more of a bug fix than a breaking change. At least that's what I'm thinking ATM, so we should be able to introduce this fix into v7 (and maybe backport it to v6).

I've cherry-picked your commits into a separate PR. I've resolved the conflicts and I've made similar changes to other operators that have the same issue. Thanks for your work. And your patience.

Closing this to address it in #6410 - which includes your work.

[e-davidson]

@cartant
Thank you for moving this forward and I'm glad I was able to assist.