chore: bump TypeScript to 4.0.1-rc #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
approved these changes
Aug 15, 2020
|
|
||
| it('should support rest tuples', () => { | ||
| let explicit: Cons<A, B[]>; | ||
| let inferred = explicit!; // $ExpectType [arg: A, ...rest: B[]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR bumps TypeScript to
4.0.1-rc. Almost no changes were needed:npm run linteffects no failures.npm run testsees all tests pass with no compile errors.npm run build:packagebuilds with no compile errors.npm run dtslinteffected a single failure that was due to named tuple elements being a thing in TS4. (It seems the file with this change had CRLF line endings. They're now LF, hence the large diff. The change is on line 71.)IMO, we might as well bump this now. Given that it will allow us to remove so many overloads, I think we should be choosing TS4 as the minimum supported version for v7.
Note that this change will affect the Google merge, as they're using TypeScript 3.8.2. 😬
Related issue (if exists): None