refactor(Subscription): minor size reduction #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduces the size of `Subscription` slightly. - Moves back to a single property for single parent, many parents, scenarios - Updates the type of `Teardown` to not be so loose. `Function` shouldn't be used.
benlesh
force-pushed
the
refactor/Subscription-minor-code-golf
branch
from
1f0c640
to
5141183
Compare
cartant
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
LGTM. I can see that this restores one of Benedikt's perf changes. FWIW, I'm planning on taking a closer look at some perf-related aspects of the codebase - but not until after I've written the next week's talk. I built the V8 source, yesterday, so that I can use d8. It's been a long time since I last dealt with a C++ project that takes as long to build as that one does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teardownto not be so loose. does not may any sense there.