Code

refactor: smallify all the things#5729

Code

Merged

benlesh merged 140 commits intoReactiveX:masterReactiveX/rxjs:masterfrom benlesh:refactor/smallify-all-the-thingsbenlesh/rxjs:refactor/smallify-all-the-thingsCopy head branch name to clipboardSep 23, 2020

+3,508-5,594

Commits

Commits on Sep 11, 2020

• fix(scan): proper indexes when seed is not supplied

  Show description for f93fb9c
  benlesh

  committed
  f93fb9c

  Copy full SHA for f93fb9c

Commits on Sep 13, 2020

• refactor(groupBy): reduce the size of the implementation

  Show description for da73377
  benlesh

  committed
  da73377

  Copy full SHA for da73377

• refactor: fix up the name, remove the 2

  benlesh

  committed
  dc79c3a

  Copy full SHA for dc79c3a

• refactor: smaller still

  Show description for ed841b4
  benlesh

  committed
  ed841b4

  Copy full SHA for ed841b4

• refactor: Add OperatorSubscriber, update map

  Show description for 32f9619
  benlesh

  committed
  32f9619

  Copy full SHA for 32f9619

• refactor(filter): smaller

  Show description for 5a49c1d
  benlesh

  committed
  5a49c1d

  Copy full SHA for 5a49c1d

• refactor(skip): Make implementation smaller

  Show description for df84881
  benlesh

  committed
  df84881

  Copy full SHA for df84881

• refactor(take): smaller implementation

  Show description for 38739ea
  benlesh

  committed
  38739ea

  Copy full SHA for 38739ea

• refactor(takeUntil): smaller implementation

  Show description for f3e422e
  benlesh

  committed
  f3e422e

  Copy full SHA for f3e422e

• refactor(takeWhile): smaller implementation

  benlesh

  committed
  c9f7517

  Copy full SHA for c9f7517

• refactor(count): smaller implementation

  benlesh

  committed
  49bcdd3

  Copy full SHA for 49bcdd3

• refactor(bufferTime): Use OperatorSubscriber instead

  benlesh

  committed
  e94f2cc

  Copy full SHA for e94f2cc

• refactor(dematerialize): smaller impl

  benlesh

  committed
  c9ea983

  Copy full SHA for c9ea983

• refactor(distinct): smaller impl

  benlesh

  committed
  b33923e

  Copy full SHA for b33923e

• refactor(distinctUntilChanged): smaller implementation

  benlesh

  committed
  eaa7dc1

  Copy full SHA for eaa7dc1

• refactor(every): smaller impl

  benlesh

  committed
  05ac435

  Copy full SHA for 05ac435

• refactor(exhaust): smaller impl

  benlesh

  committed
  c894dd8

  Copy full SHA for c894dd8

• refactor(exhaustMap): smaller impl

  benlesh

  committed
  990bec5

  Copy full SHA for 990bec5

• refactor(expand): smaller impl

  benlesh

  committed
  a18d33e

  Copy full SHA for a18d33e

• refactor(finalize): smaller impl

  benlesh

  committed
  723b5c1

  Copy full SHA for 723b5c1

• refactor(find): smaller impl

  benlesh

  committed
  adceb42

  Copy full SHA for adceb42

• refactor(ignoreElements): smaller impl

  benlesh

  committed
  59cb30a

  Copy full SHA for 59cb30a

• refactor(isEmpty): smaller impl

  benlesh

  committed
  65f0e69

  Copy full SHA for 65f0e69

• refactor(map): a little smaller still

  benlesh

  committed
  bf86f68

  Copy full SHA for bf86f68

• refactor(mapTo): smaller impl

  benlesh

  committed
  03d3c65

  Copy full SHA for 03d3c65

• refactor(materialize): smaller impl

  benlesh

  committed
  2023129

  Copy full SHA for 2023129

• refactor(pairwise): smaller impl

  benlesh

  committed
  22b40ed

  Copy full SHA for 22b40ed

• chore: golden file update for takeUntil actually accepting ObservableInput

  benlesh

  committed
  cbc341f

  Copy full SHA for cbc341f

• refactor(mergeMap): Use OperatorSubscriber instead

  benlesh

  committed
  2dbc7ec

  Copy full SHA for 2dbc7ec

• fix(windowTime): Passing no creation interval will now properly open new window when old one closes

  Show description for cbd0ac0
  benlesh

  committed
  cbd0ac0

  Copy full SHA for cbd0ac0

• refactor(buffer): smaller impl

  benlesh

  committed
  0656c5d

  Copy full SHA for 0656c5d

• refactor(delayWhen): smaller impl

  benlesh

  committed
  4e1e525

  Copy full SHA for 4e1e525

Commits on Sep 14, 2020

• refactor(throttle): smaller impl

  benlesh

  committed
  bbe90ab

  Copy full SHA for bbe90ab

• refactor(bufferToggle): smaller impl

  benlesh

  committed
  2baf5bf

  Copy full SHA for 2baf5bf

• refactor(windowToggle): smaller impl

  benlesh

  committed
  5cad812

  Copy full SHA for 5cad812

• refactor(bufferCount): Smaller impl

  benlesh

  committed
  143ee68

  Copy full SHA for 143ee68

• fix(delay): proper handling of absolute time passed as delay

  Show description for 8ae89b1
  benlesh

  committed
  8ae89b1

  Copy full SHA for 8ae89b1

• refactor(sample): smaller impl

  benlesh

  committed
  bf51b9d

  Copy full SHA for bf51b9d

• refactor(sampleTime): derive from sample and interval

  benlesh

  committed
  1efcf14

  Copy full SHA for 1efcf14

• refactor(observeOn): smaller impl

  benlesh

  committed
  7c3f4e1

  Copy full SHA for 7c3f4e1

• refactor(subscribeOn): much smaller (facepalm edition)

  benlesh

  committed
  defc580

  Copy full SHA for defc580

• refactor(defaultIfEmpty): smaller impl

  benlesh

  committed
  a8b0496

  Copy full SHA for a8b0496

• refactor(skipLast): smaller impl

  benlesh

  committed
  70d0424

  Copy full SHA for 70d0424

Commits on Sep 15, 2020

• chore: update golden files

  benlesh

  committed
  cd32519

  Copy full SHA for cd32519

• Merge branch 'refactor/groupBy-make-smaller' into refactor/smallify-all-the-things

  benlesh

  committed
  3b1286c

  Copy full SHA for 3b1286c

• refactor(groupBy): A little smaller still, add comments

  benlesh

  committed
  12f9ff6

  Copy full SHA for 12f9ff6

• refactor(mergeScan): smaller impl

  benlesh

  committed
  4f7ea8f

  Copy full SHA for 4f7ea8f

• chore: update golden files

  benlesh

  committed
  0c2805d

  Copy full SHA for 0c2805d

• refactor(debounce): smaller impl

  benlesh

  committed
  0146716

  Copy full SHA for 0146716

• refactor(withLatestFrom): smaller impl

  benlesh

  committed
  bda9555

  Copy full SHA for bda9555

• refactor(debounceTime): smaller impl

  benlesh

  committed
  64b7b58

  Copy full SHA for 64b7b58

• refactor(windowWhen): smaller impl

  benlesh

  committed
  ee64a89

  Copy full SHA for ee64a89

• refactor(windowCount): smaller impl

  benlesh

  committed
  5621095

  Copy full SHA for 5621095

• refactor(bufferWhen): smaller impl

  benlesh

  committed
  c914c53

  Copy full SHA for c914c53

• refactor(single): smaller impl

  benlesh

  committed
  9f63426

  Copy full SHA for 9f63426

• refactor(window): smaller impl

  benlesh

  committed
  7523e77

  Copy full SHA for 7523e77

• refactor(audit): smaller impl

  benlesh

  committed
  8a2a08c

  Copy full SHA for 8a2a08c

• refactor(throttleTime): using OperatorSubscriber

  benlesh

  committed
  b32d04c

  Copy full SHA for b32d04c

• refactor(switchMap): smaller impl

  benlesh

  committed
  02d32a8

  Copy full SHA for 02d32a8

• refactor: remove unused imports

  benlesh

  committed
  bd1ecb9

  Copy full SHA for bd1ecb9

• Merge branch 'fix/scan-proper-indexing' into refactor/smallify-all-the-things

  benlesh

  committed
  9c592f7

  Copy full SHA for 9c592f7

• refactor(scan): even smaller

  benlesh

  committed
  c3f92a5

  Copy full SHA for c3f92a5

• refactor: remove unused imports

  benlesh

  committed
  c092714

  Copy full SHA for c092714

• refactor(skipUntil): smaller impl

  benlesh

  committed
  9b9d4fd

  Copy full SHA for 9b9d4fd

• chore: Remove unused types

  benlesh

  committed
  7a207c5

  Copy full SHA for 7a207c5

• refactor(repeatWhen): smaller impl

  benlesh

  committed
  9559dce

  Copy full SHA for 9559dce

• refactor(catchError): smaller impl

  benlesh

  committed
  f278105

  Copy full SHA for f278105

• refactor(sequenceEqual): smaller impl

  benlesh

  committed
  78207a6

  Copy full SHA for 78207a6

• refactor(retryWhen): smaller impl

  benlesh

  committed
  473c9c3

  Copy full SHA for 473c9c3

• refactor(catchError): even smaller

  benlesh

  committed
  b612901

  Copy full SHA for b612901

• refactor: add wrappedLift (should have been a few commits ago, oops)

  benlesh

  committed
  f81e274

  Copy full SHA for f81e274

• refactor(throttle): a bit smaller

  benlesh

  committed
  cf5c3ef

  Copy full SHA for cf5c3ef

• refactor(skipUntil): even smaller

  benlesh

  committed
  e539538

  Copy full SHA for e539538

• refactor(expand): even smaller

  benlesh

  committed
  f812780

  Copy full SHA for f812780

• refactor(bufferToggle): even smaller

  benlesh

  committed
  4081eae

  Copy full SHA for 4081eae

• refactor(skipWhile): smaller impl

  benlesh

  committed
  d51cc37

  Copy full SHA for d51cc37

• refactor(throwIfEmpty): smaller impl

  benlesh

  committed
  26b5462

  Copy full SHA for 26b5462

• refactor(takeLast): smaller impl

  benlesh

  committed
  f5c3f69

  Copy full SHA for f5c3f69

• refactor(mergeMap): smaller still

  benlesh

  committed
  e125569

  Copy full SHA for e125569

• refactor(refCount): smaller impl

  benlesh

  committed
  b00427d

  Copy full SHA for b00427d

• refactor(ConnectableObservable/multicast): get rid of Object.create, make it smaller.

  benlesh

  committed
  51d6e21

  Copy full SHA for 51d6e21

• refactor(windowWhen): remove unused types

  benlesh

  committed
  5491310

  Copy full SHA for 5491310

• refactor(race/raceWith): smaller impl, remove stankyLift

  benlesh

  committed
  ef16d8d

  Copy full SHA for ef16d8d

• refactor: remove unused inner and outer subscribers

  benlesh

  committed
  45452ca

  Copy full SHA for 45452ca

• refactor: move subscribeTo, remove cruft

  Show description for 2880b5b
  benlesh

  committed
  2880b5b

  Copy full SHA for 2880b5b

• refactor: Remove stankyLift, delete cruft

  Show description for 6ed55b1
  benlesh

  committed
  6ed55b1

  Copy full SHA for 6ed55b1

• refactor(generate): smaller impl

  benlesh

  committed
  b0c2b4a

  Copy full SHA for b0c2b4a

• fix(fromEvent): properly teardown for arraylike targets

  Show description for 066de74
  benlesh

  committed
  066de74

  Copy full SHA for 066de74

• refactor(Subject): smaller impl

  benlesh

  committed
  7fd28f3

  Copy full SHA for 7fd28f3

Commits on Sep 16, 2020

• refactor(Notification): smaller impl

  benlesh

  committed
  7b2e9b3

  Copy full SHA for 7b2e9b3

• refactor(Observable): more code golf

  benlesh

  committed
  9d4294c

  Copy full SHA for 9d4294c

• refactor(not): smaller impl

  Show description for a2ad641
  benlesh

  committed
  a2ad641

  Copy full SHA for a2ad641

• refactor: add array item removal utility

  benlesh

  committed
  a01f107

  Copy full SHA for a01f107

• refactor: Remove SubjectSubscriber entirely

  benlesh

  committed
  a0a5a5d

  Copy full SHA for a0a5a5d

• refactor: Fix broken while loop in canReportError

  Show description for 675ffe3
  benlesh

  committed
  675ffe3

  Copy full SHA for 675ffe3

Commits on Sep 17, 2020

• refactor: remove unused import

  benlesh

  committed
  3a0e650

  Copy full SHA for 3a0e650

• refactor(subjects): Smaller subjects

  benlesh

  committed
  f1dcada

  Copy full SHA for f1dcada

• refactor(bufferTime): smaller still

  benlesh

  committed
  e9f2701

  Copy full SHA for e9f2701

• refactor(windowTime): smaller still

  benlesh

  committed
  580d9b8

  Copy full SHA for 580d9b8

• chore: update golden files

  benlesh

  committed
  d5cd238

  Copy full SHA for d5cd238

• refactor(windowTime): a little smaller

  benlesh

  committed
  75b0a34

  Copy full SHA for 75b0a34

• refactor(groupBy): A little more

  benlesh

  committed
  8635dc6

  Copy full SHA for 8635dc6

• refactor(timeout): reduce the size of the argument parsing

  benlesh

  committed
  ddc7db4

  Copy full SHA for ddc7db4

Commits on Sep 20, 2020

• refactor: remove unnecessary optional chaining

  benlesh

  committed
  834353e

  Copy full SHA for 834353e

• refactor(materialize): use a semicolon, not comma.

  benlesh

  committed
  21f7fc3

  Copy full SHA for 21f7fc3

• refactor(bufferWhen): remove unnecessary isComplete boolean

  benlesh

  committed
  4448443

  Copy full SHA for 4448443

Commits on Sep 21, 2020

• refactor(window): ensure teardown isn't called twice, add comments

  benlesh

  committed
  3009efd

  Copy full SHA for 3009efd

• refactor(withLatestFrom): remove unnecessary/incorrect typing, use inferrence

  benlesh

  committed
  31d297a

  Copy full SHA for 31d297a

• docs(OperatorSubscriber): add comments

  benlesh

  committed
  30d429c

  Copy full SHA for 30d429c

• fix(AsyncSubject): fix reentrancy issue in complete

  Show description for 9e00f11
  benlesh

  committed
  9e00f11

  Copy full SHA for 9e00f11

• refactor: Add underscore to name of internal API checkFinalizedStatuses

  benlesh

  committed
  29dd6ec

  Copy full SHA for 29dd6ec

• feat(skipLast): counts zero or less will mirror the source

  Show description for 02e113b
  benlesh

  committed
  02e113b

  Copy full SHA for 02e113b

• refactor(Notification): improve readability of large ternary.

  benlesh

  committed
  fb92045

  Copy full SHA for fb92045

• chore: update golden files

  benlesh

  committed
  f5b29bf

  Copy full SHA for f5b29bf

• chore: update comment on thrown error

  benlesh

  committed
  ce8804e

  Copy full SHA for ce8804e

Commits on Sep 22, 2020

• refactor(timeout): remove unnecessary falsy check

  benlesh

  committed
  c21b62c

  Copy full SHA for c21b62c

• refactor(windowCount): remove unnecessary assignment

  benlesh

  committed
  ed8c597

  Copy full SHA for ed8c597

• refactor(windowToggle): remove unnecessary assignment

  benlesh

  committed
  f9550f3

  Copy full SHA for f9550f3

• refactor(windowWhen): fix types, ensure window subject is released

  benlesh

  committed
  b9938e2

  Copy full SHA for b9938e2

• refactor(mergeMap): ensure buffered values are released.

  benlesh

  committed
  0733183

  Copy full SHA for 0733183

• refactor(debounceTime): unify emit approach. Add comments.

  benlesh

  committed
  006c118

  Copy full SHA for 006c118

• refactor(delay): Ensure buffer is released.

  benlesh

  committed
  732802c

  Copy full SHA for 732802c

• refactor(mergeScan): Ensure buffered values are released.

  benlesh

  committed
  aae8d8e

  Copy full SHA for aae8d8e

• refactor(mergeMap): Ensure buffer is released on all teardown, not just completion.

  benlesh

  committed
  f73a80b

  Copy full SHA for f73a80b

• refactor(expand): release buffer. Improved efficiency. Add comments.

  Show description for cc8cf6f
  benlesh

  committed
  cc8cf6f

  Copy full SHA for cc8cf6f

• refactor(mergeMap): slight efficiency improvement. Adds comments

  benlesh

  committed
  34ebee2

  Copy full SHA for 34ebee2

• refactor(delayWhen): Clean up, add comments.

  benlesh

  committed
  b567397

  Copy full SHA for b567397

• refactor(mergeScan): unify approach with mergeMap

  benlesh

  committed
  efabb33

  Copy full SHA for efabb33

• refactor(windowTime): ensure buffer is released. Clean up code.

  benlesh

  committed
  d2853b1

  Copy full SHA for d2853b1

• refactor(buffer): Ensure buffered values are released on teardown.

  benlesh

  committed
  2474dea

  Copy full SHA for 2474dea

• refactor(delayWhen): remove unnecessary unsubscribe

  benlesh

  committed
  891d6da

  Copy full SHA for 891d6da

• docs(scan): add comments

  benlesh

  committed
  affa716

  Copy full SHA for affa716

• docs(map): add comments

  benlesh

  committed
  58c8923

  Copy full SHA for 58c8923

• docs(filter): add comments

  benlesh

  committed
  415dd2b

  Copy full SHA for 415dd2b

• docs(mapTo): add comments

  benlesh

  committed
  61ef56d

  Copy full SHA for 61ef56d

Commits on Sep 23, 2020

• refactor(repeatWhen): remove unnecessary Subscription allocation

  benlesh

  committed
  e9bff8e

  Copy full SHA for e9bff8e

• refactor(retryWhen): remove unnecessary Subscription allocation

  benlesh

  committed
  529ad62

  Copy full SHA for 529ad62

• refactor: add underscore to protected method _throwIfClosed

  benlesh

  committed
  cee182e

  Copy full SHA for cee182e

• chore: update golden files

  benlesh

  committed
  6241024

  Copy full SHA for 6241024

• refactor(groupBy): remove unnecessary return

  benlesh

  committed
  33ec81c

  Copy full SHA for 33ec81c