Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(versioning): add versioning to docs website #5792

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

niklas-wortmann
Copy link
Member

No description provided.

@benlesh
Copy link
Member

benlesh commented Oct 6, 2020

I'm not sure which one of these to look at? #5793

@niklas-wortmann
Copy link
Member Author

Sorry @benlesh this one is the v7 docs merging in the master branch the other one is the V6 branch in the 6.x branch. The changes are pretty much identical though

@benlesh
Copy link
Member

benlesh commented Oct 7, 2020

Overall, this looks fine to me... however, I do think we had discussed trying to do something with sub directories instead? I guess I would like to more about how all of this works. We're deploying more than one version of the site?

@benlesh
Copy link
Member

benlesh commented Oct 7, 2020

I see.. it looks like angular is doing a thing with v6.angular.io, v7.angular.io, .... , angular.io (current), next.angular.io

I guess my only concern with that is it's not super intuitive to switch or know which one you're looking at. Particularly on mobile.

@benlesh
Copy link
Member

benlesh commented Oct 13, 2020

This needs rebased as well. Overall LGTM.

@niklas-wortmann
Copy link
Member Author

rebased. Just to sum up the plan I had for the docs versioning:
next.rxjs.dev always shows the docs of the upcoming major release
rxjs.dev shows the latest stable major version
vX.rxjs.dev will have the latest docs version for that major release

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase and merge when you're ready, please.

@niklas-wortmann niklas-wortmann merged commit c746fec into ReactiveX:master Oct 31, 2020
@niklas-wortmann niklas-wortmann deleted the versioning/v7 branch October 31, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants