chore: add triple-slash ref to asynciterable #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
niklas-wortmann
approved these changes
Oct 11, 2020
benlesh
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a triple-slash
libreference toesnext.asynciterableas per the TypeScript recommendation/suggestion linked to in the accompanying comment.I've tested this locally and it resolves the issue with
unknownbeing inferred in situations in which thetsconfig.jsondoes not specify a sufficiently-up-to-datelib.We could add
libreferences for any other types we depend upon - likePromise- but I figured we ought to keep this minimal and address only the problems that we've seen so far to minimize and unintended consequences.Related issue (if exists): #5708