Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multicast,share,refCount,shareReplay): enable synchronous firehose #5834

Closed
wants to merge 2 commits into from
Closed

fix(multicast,share,refCount,shareReplay): enable synchronous firehose #5834

wants to merge 2 commits into from

Commits on Oct 16, 2020

  1. fix(multicast,share,refCount,shareReplay): enable synchronous firehose 

    - use known subscriber when possible instead of returned subscription
- remove unused unsubscribe from refCount Operator
- add teardown logic before calling subscribe when possible
- enable remaining synchronous firehose tests

fixes ReactiveX#5658
    @miginmrs
    miginmrs committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    1b7ff2c View commit details
    Browse the repository at this point in the history

  2. fix(connectable): update api guardian 

    ConnectableObservable contains new properties:
* _waiting: boolean, it indicates whether _connection is a not yet subscription to source or not
* prepare: ()=>Subscription, internal, is called to get the subscription used for the next `connect`
    @miginmrs
    miginmrs committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    48bf9bf View commit details
    Browse the repository at this point in the history