-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filter.ts #5937
Update filter.ts #5937
Conversation
Remove helpful type at the beginning because it actually was incorrectly returning type never in some cases.
Remove filter test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this change should be accompanied by a failing test that's fixed by the removal of the signature - i.e. something that actually demonstrates the problem.
I would think that if your predicate unconditionally returns |
I suspect that predicates that return |
@leggechr I've added a test that fails if the signature is not removed. If this isn't representative of the code that effected the bug, could you please add a test for that use case, too? @benlesh This is going to be a problem with any other signatures that also rely upon matching predicates that return |
Hey! Yes that is the correct use case. Thanks for updating. |
@cartant it looks like this problem may exist with |
Related: #5987 |
Description:
Remove helpful type at the beginning because it actually was incorrectly returning type never in some cases.