Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add test from #5932 and plug leak in share #6029

Merged
merged 3 commits into from
Feb 19, 2021
Merged

fix: add test from #5932 and plug leak in share #6029

merged 3 commits into from
Feb 19, 2021

Commits on Feb 16, 2021

  1. test: add shareReplay leak test

    @cartant
    cartant committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bedb6cf View commit details
    Browse the repository at this point in the history

  2. fix: null inner subscription in share

    @cartant
    cartant committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    285c6fd View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. fix(share): don't have the subscriber capture itself in a closure 

    Resolves an issue where we were inadvertantly returning a teardown that was effectively adding a closure to a subscriber to itself.

Basically it was doing something like this:

```ts
new Observable(subscriber => {
    return () => {
        subscriber.unsubscribe();
    };
});
```
    @benlesh
    benlesh committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    67b8035 View commit details
    Browse the repository at this point in the history