Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mergeScan tests to run mode #6176

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

jakovljevic-mladen
Copy link
Member

Description:
Updated mergeScan tests to use run mode.

Related issue (if exists):
None

Copy link
Member Author

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes and a question.

spec/operators/mergeScan-spec.ts Show resolved Hide resolved
spec/operators/mergeScan-spec.ts Show resolved Hide resolved
spec/operators/mergeScan-spec.ts Show resolved Hide resolved
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Comment on lines +61 to +66
const t = time(' --| '); // t = 2
// --|
// --|
// --|
// --|
// --|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +89 to +94
const t = time(' -----|'); // acc = []; x = 'b'; acc.concat(x) = ['b']; t = 5
// -----| acc = []; x = 'c'; acc.concat(x) = ['c']
// -----| acc = ['b']; x = 'd'; acc.concat(x) = ['b', 'd']
// -----| acc = ['c']; x = 'e'; acc.concat(x) = ['c', 'e']
// -----| acc = ['b', 'd']; x = 'f'; acc.concat(x) = ['b', 'd', 'f']
// -----| acc = ['c', 'e']; x = 'g'; acc.concat(x) = ['c', 'e', 'g']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cartant cartant merged commit f499eb8 into ReactiveX:master Mar 27, 2021
@jakovljevic-mladen jakovljevic-mladen deleted the mergeScan_run_mode branch March 27, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants